TE-2659 Fix coverage with remote xdist workers#18636
Merged
Conversation
|
Your PR has finished running tests. There were no failures. |
michaelyoungstrom
approved these changes
Jul 24, 2018
Contributor
michaelyoungstrom
left a comment
michaelyoungstrom
left a comment
There was a problem hiding this comment.
This looks good to me, and thanks for submitting a PR to pytest-cov!
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Thursday, July 26, 2018. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working around a bug in pytest-cov by explicitly enumerating the modules to be covered on the pytest command line. I also had to expand the rsync directories to cover all the code for which coverage is measured; otherwise setup fails with
ValueError: arg lms not relative to an rsync root.We can remove some of this code if the PR above gets included in a pytest-cov release.